cisagov / cisagov/pshtt

Move utils.format_domains call into main pshtt lib

Open
#133 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
693
Forks
91
PR merge metrics
No merged PRs in 30d

Description

Instead of just doing it in the CLI. Currently, non-CLI uses of pshtt are forced to remember to call the function themselves in order to get the same level of sanitization.

Contributor guide

Open the contributing guide

Research direction

Inspect where the CLI currently calls utils.format_domains and identify the main pshtt library entry point used by non-CLI callers. Compare the sanitized results from both paths, then run the existing test suite to verify that domain formatting is applied consistently outside the CLI as well.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.