cisagov / cisagov/development-guide

Add a section about "things to keep in mind when reviewing a PR".

Open
#49 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
282
Forks
72
PR merge metrics
No merged PRs in 30d

Description

That is a good point, although we devs tend to have a hard time knowing or remembering what normies know and don't know. It's definitely something to keep in mind when reviewing other devs' pull requests.

This triggered a thought: Should we have a document in our dev guide that talks about reviewing PRs and has a list of thangs like this to keep in mind? I think such a document could be useful, but could also turn into a list that is too long and random to be of any use. Does 18F or TTS have a document we can borrow/steal?

_Originally posted by @jsf9k in https://github.com/cisagov/skeleton-docker/pull/51#r609700136_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.