cisagov / cisagov/crossfeed

Refactor TermsOfUse page component

Open
#2,136 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Frontend Refactor
Dominant language
TypeScript
Stars
427
Forks
66
PR merge metrics
No merged PRs in 30d

Description

💡 Summary

File: frontend/src/pages/TermsOfUse/TermsOfUse.tsx
The TermsOfUse page component contains a mixture of logic, content, and style. It needs to be broken down in to smaller, more focused subcomponents.

Motivation and context

Cleans up the code so that it is easier to evaluate and manage.

Acceptance criteria

  • Style is moved into it's own file
  • All in-line style is moved out of JSX into css classes
  • All logic is moved from JSX into variables defined by typescript
  • All areas of concern are broken off into subcomponents
  • Markup represents what is visually in the page

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading frontend/src/pages/TermsOfUse/TermsOfUse.tsx to identify the current logic, content, inline styles, and visual areas. Done means styles are in a separate file, JSX uses CSS classes, logic is represented by TypeScript variables, and distinct concerns are separated into subcomponents.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, typescript
Domain
frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.