cilium / cilium/release

Running the release tool with --dry-run should not post PRs

Open
#245 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
8
Forks
7
Avg merge
17h 16m
Merged PRs (30d)
2

Description

The flag says:

      --dry-run                   If enabled, it will not perform irreversible operations into GitHub such as: syncing GH projects, pushing tags. All changes that are done locally as well as creating and pushing PRs are also considered reversible and therefore not affected by this flag's value.

Even if posting a PR is reversible, it is surprising for the tool to push a PR when --dry-run is enabled. For instance, I was running this script to locally inspect what the tool would generate, and then it opened a PR on cilium/cilium.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the release tool's --dry-run handling and the code path that creates or pushes pull requests. Trace how the flag reaches PR creation, then verify that a dry run leaves GitHub unchanged while preserving the tool's local inspection behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, release
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.