chunky-dev / chunky-dev/chunky

Limitations of the current fog implementation

Open
#665 0 comments 1 reaction 0 assignees View on GitHub
renderer
Dominant language
Java
Stars
738
Forks
78
Avg merge
10h 5m
Merged PRs (30d)
3

Description

Below is a list of issues with the current fog implementation.

---

Fog is illuminated only by the suns position. Whether it is enabled or disabled does not matter.

Sun enabled
![image](https://user-images.githubusercontent.com/3740917/89107489-4d121600-d429-11ea-8784-6c4d38177404.png)

Sun disabled
![image](https://user-images.githubusercontent.com/3740917/89107479-323fa180-d429-11ea-8ad0-82832eef6364.png)

Sun disabled + Sky Black
![image](https://user-images.githubusercontent.com/3740917/89107515-729f1f80-d429-11ea-974b-b815c83f3392.png)

---

Emitters do not illuminate fog.

No Fog
![image](https://user-images.githubusercontent.com/3740917/89107589-08d34580-d42a-11ea-8b54-b4268261c2b7.png)

Fog
![image](https://user-images.githubusercontent.com/3740917/89107534-8b0f3a00-d429-11ea-8d78-f699f2246f6f.png)

Realworld example
![image](https://user-images.githubusercontent.com/3740917/89107705-cc541980-d42a-11ea-86e7-031b4701bed9.png)

---

Fog has a uniform color and is not tinted by the color of light. ie- Fog color on either side of stained glass is the same.

Fast Fog (Enabled)
![glass_fog2_ff-512](https://user-images.githubusercontent.com/3740917/89107359-7bdbbc80-d428-11ea-9610-c74453d7b468.png)

(Slow) Fog
![glass_fog2_sf-512](https://user-images.githubusercontent.com/3740917/89107368-8bf39c00-d428-11ea-8bfe-09f24c0974b7.png)

Realworld example
![image](https://user-images.githubusercontent.com/3740917/89107713-d7a74500-d42a-11ea-9296-f175c378a8c0.png)

---

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.