chunky-dev / chunky-dev/chunky

Lighting is not uniform underwater

Open
#1,230 0 comments 0 reactions 0 assignees View on GitHub
bug renderer
Dominant language
Java
Stars
738
Forks
78
Avg merge
10h 5m
Merged PRs (30d)
3

Description

The lighting underneath the surface of the water is not uniform. When viewed from above the surface of the water, The lighting becomes darker for the first block under the water surface, and periodic waves of brighter lighting are seen intersecting with the surface of the water at the top corners of the blocks. The next blocks underneath cut into brighter lighting and then continue with a more normal lighting.
![Emitters test-128](https://user-images.githubusercontent.com/92183530/163690519-f3b5837f-93e7-46ac-9ae3-12ea29e476e5.png)

When viewed from underneath the surface of the water, the lighting cutoffs are not visible, and a similar effect of periodic waves of brighter lighting is seen aligning with the edges of the blocks.
![Emitters test-33](https://user-images.githubusercontent.com/92183530/163690609-4b9a563a-cde4-4778-ae51-5728c5952a70.png)

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the underwater lighting artifacts shown in the attached Emitters test-128 and Emitters test-33 images, comparing views from above and below the water surface. Trace the Java rendering path that handles underwater lighting and verify that the completed change removes the dark cutoff and periodic bright waves while keeping lighting uniform across blocks.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.