chunky-dev / chunky-dev/chunky-denoiser

When using `DenoisedPathTracer` only denoised is outputted to `snapshots`

Open
#34 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
30
Forks
8
PR merge metrics
No merged PRs in 30d

Description

Tested on `Chunky 2.4.0` with #30

In past versions of the plugin both the beauty pass and the denoised beauty would be exported to `snapshots`. Currently, when using the `DenoisedPathTracer` Renderer only denoised beauties are outputted to `snapshots`. The option the `Save beauty pass` within the `Denoiser Tab` only applies to the beauty `.pfm`.There are a multitude of benefits from having the option to still export the noisy snapshots.

1) #33 shows that denoising behaviour is mixed and that when using the `Denoise Current Render` button both the noisy and denoised beauty are snapshotted. Ideally we would want consistency with how denoising works.

2) The options listed within the `Denoiser Tab` lack clarification as to what they do. Expanding the visible descriptions or adding tooltips would help clear things up.

3) Disabling or redirecting inbuilt functionality without having an option to retain defaults and to export the denoised output with a suffix, as was done in the past with `.denoised`, should be avoided.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the DenoisedPathTracer snapshot export path and compare it with the Denoise Current Render behavior. Review the Denoiser Tab's Save beauty pass option and existing snapshot naming, then verify that the noisy beauty remains available and the denoised output is exported consistently with the expected suffix.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.