chroma-core / chroma-core/chroma

Add linter rule for not using falsiness of types

Open
#701 1 comment 0 reactions 0 assignees View on GitHub
by-chroma cleanup to-discuss
Dominant language
Rust
Stars
29.3k
Forks
2.5k
Avg merge
1d 4h
Merged PRs (30d)
38

Description

In several places in our code, we have run into bugs where we rely on the falsy-ness of a type or accidentally rely on it. We should add a linter rule to make checks explicit and never do things like if {} by accident.

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue does not name any files, tests, linter, or entry point to inspect. First identify the project's linting setup and examples of accidental type falsiness; done should mean an explicit linter rule catches the described checks without unwanted violations.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.