chroma-core / chroma-core/chroma

[Bug]: logical error in command line argument check

Open
#4,474 1 comment 0 reactions 1 assignee Claimed by @itaismith View on GitHub
bug
Dominant language
Rust
Stars
29.3k
Forks
2.5k
Avg merge
1d 4h
Merged PRs (30d)
38

Description

### What happened?

.venv/lib/python3.10/site-packages/chromadb/cli/cli.py
line 50
if ["chroma", "update"] in args:
update()
return
I believe you are trying to say if both of the arguments are in the argument list
a possible correction should be:
if all(i in args for i in ["chroma", "update"]):
update()
return

I tried to see if it is new python syntax but it seems not, see example below:
{list of arg} in {list of arg} does not work
[1,2] in [2, 3]
False
[1,2] in [2, 3,1]
False
[1,2] in [2, 3,1,2]
False
[1,2] in [1,2]
False

### Versions

chroma --version
chroma 1.0.0

### Relevant log output

```shell

```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.