chroma-core / chroma-core/chroma

[Update][Ease of Use] Fix Types

Open
#2,292 1 comment 0 reactions 1 assignee Claimed by @atroyn View on GitHub
by-chroma Local Chroma
Dominant language
Rust
Stars
29.3k
Forks
2.5k
Avg merge
1d 4h
Merged PRs (30d)
38

Description

# Fix Types

Types are currently broken in many places throughout the project. Some of these, like `CollectionMetadata` have been broken for over a year. A good type system improves code correctness and hence development velocity.

We must have 𝔬𝔯𝔡𝔢𝔯.

## API Design

N/A

## [Complexity] Subtask
- [Med] Break up the very long https://github.com/chroma-core/chroma/blob/main/chromadb/api/types.py and extract validators as appropriate.
- [Med] Remove all generic #type: ignores and have MyPi pass
- [Low] Add type checking before merge on PRs so this never happens again

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.