christophergandrud / christophergandrud/simPH

ggfitStrata removes spaces from labels for strata

Open
#27 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TeX
Stars
14
Forks
6
PR merge metrics
No merged PRs in 30d

Description

First of all thank you for writing this nice package!

I was wondering if it is really necessary to remove spaces from labels for strata in ggfitStrata.R as this makes the labels less legible in the grid plot? I took the source code and commented out:

`TempData$StrataC <- gsub(" ", "", TempData$StrataC)`

The modified function seems to work fine with the case I tested it with, but maybe the removal of spaces is meant to guard against something particular that did not play a role in the simple test I ran.

I noticed the note on use of `revalue`, but could not follow how that is supposed to work. Maybe an example or more detail would help.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.