choojs / choojs/nanomorph

The tests

Open
#79 2 comments 0 reactions 1 assignee Claimed by @tunnckoCore View on GitHub
Dominant language
JavaScript
Stars
751
Forks
57
PR merge metrics
No merged PRs in 30d

Description

Heya there! :wave:

I'm deeply digging into tests, because i'm experimenting to implement virtual dom diffing, where `nanomorph` guided me at most. Diffing vdom, seems pretty smaller and easy than that here.

I believe my implementation looks good, but it's just a toy for the moment. All nanomorph tests pass, except the last one for `nested without id`.

But while digging into `test/diff.js` i found one test which have opening tag, but the closing tag is missing a slash `/` - see it here [test/diff.js#L357-L365](https://github.com/choojs/nanomorph/blob/master/test/diff.js#L357-L365). Is it intentional or is typo?

Also, the title isn't very clear to me. What should be the result? I think it should be `

`, but the title says me that it expect to be something like `
'hello'
` which not make sense to me to be correct result?

One more thing is to include the test suite (that file) in the npm package, so others can tests against it.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.