choojs / choojs/choo

Router match with and without trailing slash?

Open
#590 6 comments 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
6.8k
Forks
573
PR merge metrics
No merged PRs in 30d

Description

Hey all, ran into a funny one tonight. What are thoughts on matching the router against routes both with and without trailing slashes? For instance, if I add a route like this:

```
app.route('/about, view)
```

… should I expect it to work when navigating to both `/about` and `/about/`? Currently the latter does not. Open to thoughts! I think it’d be useful.

Contributor guide

Open the contributing guide

Research direction

No file or test is identified. Start by locating the router matching entry point and reviewing how the `/about` route is currently compared with `/about/`; done means the project has a decided, tested behavior for both trailing-slash forms.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, web-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.