chocoteam / chocoteam/choco-solver

[Documentation] Wrong specs in Implied and Reif constraints/propagators

Open
#1,087 0 comments 1 reaction 1 assignee Claimed by @cprudhom View on GitHub
bug
Dominant language
Java
Stars
779
Forks
159
Avg merge
6d 9h
Merged PRs (30d)
10

Description

Hi,

When reading the code about implied and reification constraints, I noticed there are a few specifications issues (probably copy-paste related).

Both constraints share the same spec
![image](https://github.com/chocoteam/choco-solver/assets/2706442/5afbc09e-29d1-42d2-b5be-dad6d54c2a50)
![image](https://github.com/chocoteam/choco-solver/assets/2706442/90a6260c-0e93-4d9f-b368-5beeb240e19c)
Which is correct for Reification but not true for Implication.
In addition, they both use (in their constructor) the constraint name 'ConstraintsName.REIFICATIONCONSTRAINT' which may be correct if you use it as a category, but not if you use the name as the name of the actual constraint.

On the propagator side, they also share the same spec
![image](https://github.com/chocoteam/choco-solver/assets/2706442/655f471a-8edc-4a3c-9c19-e0d2efd8f0ad)
![image](https://github.com/chocoteam/choco-solver/assets/2706442/5caec6a9-e50e-4ef8-b706-3cae029fe02f)
Which is correct for Implication but not correct for Reification

Kind regards,
Hélène

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.