chocolatey / chocolatey/choco

Chocolatey commands should accurately report if they may require administrator rights or not

Open
#3,472 0 comments 1 reaction 0 assignees View on GitHub
0 - Triaging Enhancement
Dominant language
C#
Stars
11.5k
Forks
960
PR merge metrics
No merged PRs in 30d

Description

### Checklist

- [X] I have verified this is the correct repository for opening this issue.
- [X] I have verified no other issues exist related to my request.

### Is Your Feature Request Related To A Problem? Please describe.

_No response_

### Describe The Solution. Why is it needed?

For some commands, there are situations where admin is not required. Many of these commands are just returning `true` on `MayRequireAdminAccess`. It would be ideal if they only returned true on operations that require administrator access.

### Additional Context

An example of this is `choco feature get`. It is not `choco feature list`, and so it is marked as possibly requiring admin access. It would probably be good to assess all of the `MayRequireAdminAccess` methods to ensure that they are behaving as desired.

![image](https://github.com/chocolatey/choco/assets/30301021/8bc3fad3-5df0-488c-be82-e65bbdf60d1d)

### Related Issues

- Issue #1307

Contributor guide

Open the contributing guide

Research direction

Start by locating the MayRequireAdminAccess methods used by Chocolatey commands, comparing the behavior of `choco feature get` and `choco feature list` and reviewing related issue #1307. Assess each method's administrator-access requirement and verify that commands report true only when appropriate; done means the affected commands accurately distinguish operations that may require administrator rights.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.