useRememberedArgumentsForUpgrades feature doesn't work when upgrading packages via the Lets.GetChocolatey() entry point (such as with Chocolatey GUI)
- Dominant language
- C#
- Stars
- 11.5k
- Forks
- 960
- PR merge metrics
- No merged PRs in 30d
Description
### What You Are Seeing?
As I mentioned on Discord, whenever I upgrade a package with Chocolatey GUI (e.g. VirtualBox, ImageMagick), the `--params` argument doesn't get remembered. I was requested to create an issue here.
### What is Expected?
Parameters should be remembered.
### How Did You Get This To Happen? (Steps to Reproduce)
ImageMagick is not installed.
1. `choco install imagemagick -y -f --params "InstallDevelopmentHeader=true LegacySupport=true" --version 7.1.0`
2. `choco upgrade imagemagick -y (to version 7.1.0.51)`
3. The parameters were preserved in both `imagemagick` and `imagemagick.app`. Tested also `mogrify` command that's part of legacy tools and it worked.
Then I tried this, after running choco uninstall imagemagick imagemagick.app:
1. `choco install imagemagick -y -f --params "InstallDevelopmentHeader=true LegacySupport=true" --version 7.1.0`
2. Upgraded ImageMagick through GUI
3. The only parameter shown in GUI was `--cache-location `
So I guess your 1.2.0 fix, that was mentioned on Discord, worked for choco itself but not for GUI for some reason? What does the GUI do when upgrading? I thought it would just run the choco command.
### System Details
* OS Build (In PowerShell run `[System.Environment]::OSVersion.version.tostring()`): 10.0.19045.0
* Windows PowerShell version (Run: `$PSVersionTable`): 5.1.19041.1682
* Chocolatey version (Run `choco --version`): 1.2.0
* Chocolatey GUI version: 1.1.0
### Output Log
https://gist.github.com/Destroy666x/b01e6c5435c92488d26cb7a3670d083f
Contributor guide
Assessment
This issue has not been assessed yet.