chocolatey / chocolatey/choco

Test for converting side-by-side package to a normal package not actually testing scenario

Open
#2,877 1 comment 0 reactions 1 assignee Claimed by @corbob View on GitHub
2 - Working Tests
Dominant language
C#
Stars
11.5k
Forks
960
PR merge metrics
No merged PRs in 30d

Description

### What You Are Seeing?

The test to change converting a side-by-side package to a normal package isn't installing the package as side-by-side before testing, so it's actually only testing force reinstalling a package.

### What is Expected?

The test should install the package as side-by-side before attempting to reinstall it as a normal package.

### How Did You Get This To Happen? (Steps to Reproduce)

Was looking to work off of the scenario to create a script to do this. Noticed it wasn't warning that it was side by side.

### System Details

**This is Pester test related, so these values are mostly not needed.**

* OS Build (In PowerShell run `[System.Environment]::OSVersion.version.tostring()`): N/A
* Windows PowerShell version (Run: `$PSVersionTable`): N/A
* Chocolatey version (Run `choco --version`): 1.2.0

### Output Log

Not an output log, but a screenshot of the output, followed by a screenshot what it should actually be.

![2022-10-29_08-32-15](https://user-images.githubusercontent.com/30301021/198840141-7bf080d3-d6f9-46ab-bc3a-5adac4eaf4e4.png)

![2022-10-29_08-33-23](https://user-images.githubusercontent.com/30301021/198840203-1ae96981-9d58-45a4-a7b6-3e1fadd91bac.png)

### Additional details

The line in question: https://github.com/chocolatey/choco/blob/4ea7e5380ccc33be51899d71a0a509031f859f16/tests/chocolatey-tests/commands/choco-install.Tests.ps1#L740

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.