chocolatey / chocolatey/choco

Fully qualify the path to msiexec for MsiInstaller and MsiPatchInstaller

Open
#2,573 0 comments 0 reactions 0 assignees View on GitHub
0 - Triaging Enhancement
Dominant language
C#
Stars
11.5k
Forks
960
PR merge metrics
No merged PRs in 30d

Description

It currently is just `"msiexec.exe"`

As noted in these todo comments:
https://github.com/chocolatey/choco/blob/d8ca7bad2ad64538a0c1026a9317700dbb7f03db/src/chocolatey/infrastructure.app/domain/installers/MsiInstaller.cs#L35-L36
https://github.com/chocolatey/choco/blob/d8ca7bad2ad64538a0c1026a9317700dbb7f03db/src/chocolatey/infrastructure.app/domain/installers/MsiPatchInstaller.cs#L25-L26

Contributor guide

Open the contributing guide

Research direction

Start with the TODO comments in src/chocolatey/infrastructure.app/domain/installers/MsiInstaller.cs and MsiPatchInstaller.cs. Review how each installer currently invokes msiexec.exe, then update both paths to be fully qualified and verify that both installers use the qualified executable path.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
cli, operating-systems
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.