chocolatey / chocolatey/ChocoCCM

New-CCMDeploymentStep -Type parameter feels redundant

Open
#37 1 comment 0 reactions 0 assignees View on GitHub
Enhancement
Dominant language
PowerShell
Stars
7
Forks
11
PR merge metrics
No merged PRs in 30d

Description

```ps1
$step = @{
Deployment = $Deployment.Name
Name = 'Choco Upgrade All'
TargetGroup = $Group.Name
# why is this here?
Type = 'Basic'
ChocoCommand = 'upgrade'
PackageName = 'all'
}
New-CCMDeploymentStep @step
```

I think the best way forward here is to remove the `Type` parameter completely (it's not really adding anything here) and just have the `-Script` or `-ChocoCommand` (and `-PackageName`) parameters be mandatory in their sets.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the New-CCMDeploymentStep entry point and inspect how its Type parameter and parameter sets are defined. Check the existing command behavior and tests, if present; done means Type is no longer required or accepted, while Script or ChocoCommand with PackageName is mandatory in the appropriate sets.

Written by the indexing model from the issue text.

Assessment

Tech stack
powershell
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.