chinchang / chinchang/cta.js

not compatible with hybrid app development framework like ionicframework

Open
#13 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
1.6k
Forks
143
PR merge metrics
No merged PRs in 30d

Description

it would be great if cta works with ionicframework since cta has an attractive animation features. Also this follows material design concepts I have tried integrate it with ionic material and the animation didnt work because it appending run time element into document body (ionic uses document with ). I had to modify the library. If you can give the parent element when declaring click events that would be great.

Thanks

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the click-event declaration and the runtime element appending behavior described in the issue. Confirm how CTA currently targets document.body, then define completion as allowing a parent element to be supplied so animations work inside Ionic views.

Written by the indexing model from the issue text.

Assessment

Domain
frontend, web-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.