chickensoft-games / chickensoft-games/Serialization

Generic dictionary converter to expand possible key types

Open
#140 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C#
Stars
72
Forks
6
Avg merge
6h 44m
Merged PRs (30d)
3

Description

Currently Serialization doesn't support Godot types as dictionary keys (Vector2I for example).
To avoid having to implement ReadAsPropertyName and WriteAsPropertyName for every Godot type in the Serialization.Godot library, a general solution would be preferred.

@jolexxa suggested that serializing into an intermediate json type could solve the issue. We'd like to serialize to a JSON array containing key/value pair objects.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing dictionary handling in the Serialization.Godot library and the proposed intermediate JSON representation. Trace how dictionary keys are currently serialized, then define coverage for Vector2I and other Godot key types; done means they work without individual ReadAsPropertyName and WriteAsPropertyName implementations.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.