chenglou / chenglou/react-motion

Cannot build demos on react v16

Open
#531 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
21.9k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

Hi.

I've tried to build these demos as the readme.md, however they produce many failures as below:

```
ERROR in ./demos/demo0-simple-transition/index.jsx
Module not found: Error: Cannot resolve module 'react/lib/ReactMount' in D:\Github\react-motion\demos\demo0-simple-transition
@ ./demos/demo0-simple-transition/index.jsx 1:321-352
```

To resolve this, I fixed react and react-dom version to v15.5.0. but it seems not to be the best way.
Could you please make this demos buildable on react v16?

Thanks.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with README.md and the demo entry point shown in demos/demo0-simple-transition/index.jsx, then reproduce the build using React v16. Check the reported ReactMount module-resolution failure and the other demo build failures; done means the demos build successfully on React v16 without requiring React v15.5.0.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
build-system, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.