chenglou / chenglou/react-motion

First element in array of motion elements with wrong position

Open
#436 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
21.9k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

@chenglou Thanks for making this very awesome library. I have an issue where when I draw a series of rects on a svg, the first rect is animating from the wrong position. It only happens with the first element and only when I adjust the height. I don't understand why this is occurring so any feedback or guidance would be appreciated. Thanks!

Relevant code for the rect class:

```'use strict';

import React from 'react';
import {Motion, spring} from 'react-motion';

class Bar extends React.Component {
static propTypes = {
yScale: React.PropTypes.func.isRequired,
xScale: React.PropTypes.func.isRequired,
y: React.PropTypes.number.isRequired,
y0: React.PropTypes.number,
barWidth: React.PropTypes.number.isRequired,
padding: React.PropTypes.object
};
constructor(props) {
super(props);
this.state = {
height: 0,
y: props.height - props.padding.top - props.padding.bottom
}
}

componentWillReceiveProps(nextProps) {
this.setState({height: 0, y: nextProps.height - nextProps.padding.top - nextProps.padding.bottom});
}

render() {
let props = this.props;
let y = props.height - props.yScale(props.y0) - props.padding.top - props.padding.bottom - props.yScale(props.y);
let height = props.yScale(props.y);
let x = props.xScale(props.x);

return (

{interpolatingStyle => }

);
}
}

export default Bar;

```

![screencast-2017-02-28-17-57-24](https://cloud.githubusercontent.com/assets/10728027/23438624/aec9a07a-fde0-11e6-8916-8e33fab5de4e.gif)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the supplied Bar component and reproduce the SVG rect animation while changing height, focusing on the first array element. Done means the first rect animates from the correct position under the same conditions; the issue names no repository file or test to run.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.