chengchingwen / chengchingwen/StructWalk.jl

zipped iteration should splat

Open
#13 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Julia
Stars
20
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Currently we have
```julia
StructWalk.scan(model, grad) do tupl
x, g = tupl
# ...
end
```
while I think it would be more idiomatic to pass separate arguments instead of a tuple
```julia
StructWalk.scan(model, grad) do x, g
# ...
end
```
Of course this would be a breaking change, but it would match the semantics of `map` etc...

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the StructWalk.scan entry point and inspect how its callback currently receives the tuple shown in the issue. Change the callback behavior so zipped iteration passes x and g as separate arguments, then verify the existing scan usage and any related checks reflect the new calling convention.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.