cheminfo / cheminfo/openchemlib-utils
Condition seems wrong
Open
Beginner friendly
- Dominant language
- JavaScript
- Stars
- 2
- Forks
- 2
- Avg merge
- 3m
- Merged PRs (30d)
- 1
Description
https://github.com/cheminfo/openchemlib-utils/blob/5ad34b6b75481041ffe7acdaa5a96741d6a92989/src/hose/getHoseCodesForAtomsAsFragments.ts#L45-L50
It looks like `allowedCustomLabels` is "ignored". As long as a custom label exists, it is pushed.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in src/hose/getHoseCodesForAtomsAsFragments.ts at lines 45-50 and inspect how allowedCustomLabels is used when a custom label exists. Reproduce the case with a custom label and an allowedCustomLabels value, then confirm that labels outside the allowed set are no longer pushed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100