cheminfo / cheminfo/nmrium

Parsing jcamp is too slow

Open
#376 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
80
Forks
34
Avg merge
2d 9h
Merged PRs (30d)
36

Description

https://cheminfo.github.io/nmr-displayer/#/SamplesDashboard/h26k5v1lw5s/cytisine2ddatacytisine2dhmbc-onlyjson

Parsing the jcamp takes the following time on chrome:
````
0: {action: "Before split to LDRS", time: 0}
1: {action: "Split to LDRS", time: 5314}
2: {action: "Finished parsing", time: 5800}
3: {action: "Finished countour plot calculation", time: 6122}
4: {action: "Total time", time: 6122}
```

On firefox:
```
0: Object { action: "Before split to LDRS", time: 0 }
1: Object { action: "Split to LDRS", time: 14 }
2: Object { action: "Finished parsing", time: 442 }
3: Object { action: "Finished countour plot calculation", time: 622 }
4: Object { action: "Total time", time: 622 }
```

Splitting LDRS is much slower in chrome. This is related to a `jcamp.split(/[\r\n]+##/);`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.