cheminfo / cheminfo/nmrium

Don't remap database

Open
#1,641 4 comments 0 reactions 1 assignee Claimed by @hamed-musallam View on GitHub
enhancement
Dominant language
TypeScript
Stars
80
Forks
34
Avg merge
2d 9h
Merged PRs (30d)
36

Description

The complexity of this code seems to high:

https://github.com/cheminfo/nmrium/blob/92d1c938562ba4f5004b6bf41bf62e4216e48079/src/data/data1d/database.ts#L153-L184

And it does not seem justified. We are expected to be able to display directly, without any change, the result of the database.

I think the table:

![image](https://user-images.githubusercontent.com/1484241/180450038-4d248191-6035-4193-82b6-fd983813b418.png)

Should be a one level row table and the cells containing delta, js could be a list of divs with fixed height.

Sorting in the database panel could also be removed.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.