cheminfo / cheminfo/nmrium

Non intuitive close icon

Open
#1,449 2 comments 0 reactions 1 assignee Claimed by @hamed-musallam View on GitHub
Dominant language
TypeScript
Stars
80
Forks
34
Avg merge
2d 9h
Merged PRs (30d)
36

Description

Currently we have the icon 'x' to cancel a change.

![image](https://user-images.githubusercontent.com/1484241/159890144-63a71f0c-2f1d-4dad-9b83-f6eefc712781.png)

It appears however that this is not intuitive because we can see in some cases 'live' changes and we don't expect that clicking on 'x' that seems like closing a dialog box would actually revert the changes.

If it reverts changes we should replace the 'x' icon by 'ban':

![image](https://user-images.githubusercontent.com/1484241/159889926-e36d3bd1-44d7-457a-a164-6c3cba03adfa.png)

If it just closes the dialog box without reverting anything we can keep the 'x'.

@targos @stropitek sounds ok to you ?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.