cheminfo / cheminfo/nmrium

Feedback on cursor tracking

Open
#1,440 0 comments 0 reactions 1 assignee Claimed by @hamed-musallam View on GitHub
Dominant language
TypeScript
Stars
80
Forks
34
Avg merge
2d 9h
Merged PRs (30d)
36

Description

## Horizontal bar in 1D spectra

I'm not sure how useful it is to have the full crosshair with horizontal bar in 1D. Maybe just the vertical on would be enough since the interactions are 1-dimensional?

https://user-images.githubusercontent.com/2352663/158786391-0d426c80-9dd5-4e84-8992-0ffb2440bd76.mov

## Tracking changes depending on the tool in 1D spectra

With most tools, the tracking is the same as the default, but for two of them it is different. While the tool itself could add more annotations during mouse move, I think it would still be useful to display the vertical line to precisely know the X position:
- In "peaks picking", I find it unintuitive to only see the position on the spectrum
- In "peaks picking" and "phase correction", there is only the value that follows the mouse cursor. If the vertical line was here with it, it would be less weird.

https://user-images.githubusercontent.com/2352663/158787905-e0df3317-50e4-43df-a01a-cd651b0dec1f.mov

## Inconsistencies in 2D (1D traces)

- As above, I think it would be better to only show one line (vertical at the top, horizontal on the left).
- The ppm value could also be tracked next to the cursor.
- The "Y" value is a large number, so maybe showing it in scientific notation may be easier to read?
- The "Y" value is an intensity, I think, not a "ppm"
- The Intensity is always 0, so we could avoid showing it
- I think to be consistent with the 2D graph, I would change from "X","Y","Intensity" to "Fx (nucleus), "Intensity".

https://user-images.githubusercontent.com/2352663/158788350-1ee4a136-b16e-414e-a2f2-7b8997611cce.mov

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.