cheminfo / cheminfo/common-spectrum

should be peak picking a method of common-spectrum or method specific?

Open
#1 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3
Forks
2
PR merge metrics
No merged PRs in 30d

Description

I started working a bit on the peak picking (https://github.com/kjappelbaum/xrd-analysis) but it seems to me that the code is not really dependent on the specific spectrum type (except for the peak shape). Maybe this should then be moved to common-spectrum?

What do you think @lpatiny ?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the peak-picking work in the linked xrd-analysis repository and comparing it with common-spectrum. Determine whether the implementation depends on spectrum type beyond peak shape, then document or agree on the appropriate ownership before moving anything. Done means the method's placement has a clear decision and the affected behavior remains covered by the project's checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.