cheminfo / cheminfo/cheminfo-types

Question: could it be possible to accept other TypedArrays?

Open
#88 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2
Forks
3
Avg merge
1m
Merged PRs (30d)
1

Description

The most useful one to add seems Float32Array, but maybe any array could be better ?

One current issue is that a Typed Array (8,16,32) will have to be converted to 64 and takes time and extra memory.

Currently only accepts extensions of `DoubleArray`, [from this interface.](https://github.com/cheminfo/cheminfo-types/blob/9cdd1340ae9f72793a6b82c480f1615347b592ae/src/measurements/common/MeasurementXY.ts#L6)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with src/measurements/common/MeasurementXY.ts and inspect the current DoubleArray constraint. Determine which TypedArray inputs the project should support, especially Float32Array, and document that scope before changing the interface. Done means the accepted types and conversion behavior are explicit and covered by the relevant type checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.