cheminfo / cheminfo/cheminfo-types
Remove this property
- Dominant language
- TypeScript
- Stars
- 2
- Forks
- 3
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Description
https://github.com/cheminfo/cheminfo-types/blob/d203027362f11d1388936975160a7568b4e7939a/src/spectra/core/MeasurementResult.ts#L12-L14
I would not allow free addition of properties like that. Each analysis should have their own well specified derived data and corresponding field name
Contributor guide
No contributing guide indexed for this repository
Research direction
Open src/spectra/core/MeasurementResult.ts at lines 12–14 and inspect how the property is used in the surrounding type. Then trace the analysis result types that depend on it and determine the expected named derived-data fields; the work is done when free property additions are no longer permitted and each analysis has a specified field.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100