cheminfo / cheminfo/cheminfo-types

should a peak extend QuantityWithUnit or just be QuantityWithUnit?

Open
#27 2 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
TypeScript
Stars
2
Forks
3
Avg merge
1m
Merged PRs (30d)
1

Description

if we just say every peak is a `QuantityWithUnit` or a `RangeWithUnit` where do we distinguish transmittance/ads:
- do we have an additional field for this "type" of data in the type
- do we have it as an additional attribute for the peak
- similar question is about the "kind" we have in IR, i think this is a custom label for IR and nothing that is there in general

Contributor guide

No contributing guide indexed for this repository

Research direction

No files or tests are identified. Review the existing TypeScript definitions for QuantityWithUnit, RangeWithUnit, peaks, and the IR-specific kind, then decide how transmittance/ads and custom IR labels should be represented. Done means the data-model decision is recorded and the affected type definitions consistently reflect it.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.