cheminfo / cheminfo/analysis

getMeasurementXY is too loose

Open
#17 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1
Forks
1
PR merge metrics
No merged PRs in 30d

Description

https://github.com/cheminfo/analysis/blob/274c2a7326a3046be976d6bd5e3613ad09d00e3e/packages/base-analysis/src/util/getMeasurementXY.ts#L26

There are a lot of cases where the function can return `undefined` and then this pollutes the [Analysis class](https://github.com/cheminfo/analysis/blob/274c2a7326a3046be976d6bd5e3613ad09d00e3e/packages/base-analysis/src/Analysis.ts) where most methods can also return `undefined` and the user always has to check if a value was returned.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.