Reaper doesn't like sudo'd processes
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 133
- Forks
- 73
- Avg merge
- 8h 20m
- Merged PRs (30d)
- 2
Description
In the case where the process doing shell-out-ing is an unpriv'd user, and the command being run either directly or indirectly ends up with elevated perms, we can end up with a situation where the kill() call in reap_errant_child fails with EPERM.
We should probably just ignore it like we do with ESRCH, maybe with a warning that reaping failed due to process permissions.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating reap_errant_child and the kill() call that currently handles ESRCH. Check how the project tests child reaping and process errors, then verify that EPERM is handled as requested, with a warning if appropriate; done means sudo-induced permission failures no longer leave reaping unsuccessful without notice.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100