Reap failure can show red herring error message
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 133
- Forks
- 73
- Avg merge
- 8h 20m
- Merged PRs (30d)
- 2
Description
If an exception is raised during run_command, we try to reap things, it will show a red herring error log that "Command exceeded allowed execution time" even though the timeout wasn't involved. We should differentiate the log message on the two places we use reap_errant_child.
In this case the exception was being raised by a faulty live_stream implementation, but there are others.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search for run_command and the two places that call reap_errant_child. Read how the exception path and timeout path are logged, including the live_stream failure case. Done means each path reports an accurate message and the exception path no longer claims that the command exceeded its allowed execution time.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100