Omnitruck Windows install.ps1 script breaks when no_proxy contains *.domain

Version:

Omnitruck

Environment:

Windows

Scenario:

Running the omnitruck script fails if the $env:no_proxy environment variable contains wildcard domain entries like *.chef.io.

Steps to Reproduce:

The cause is the Get-WebContentOnFullNet helper function. It doesn't sanitise the setting of $proxy.BypassList which must be an array of regular expressions.

$proxy = New-Object -TypeName System.Net.WebProxy

$proxy.BypassList = @( "*.chef.io" ) # will fail

$proxy.BypassList = @( "\*.chef.io" ) # will work

$proxy.BypassList = @( " *.chef.io" ) # also works

Expected Result:

Chef is installed

Actual Result:

Exception thrown - Exception setting "BypassList": "parsing "*.chef.io" - Quantifier {x,y} following nothing."

Start with the Get-WebContentOnFullNet helper in the omnitruck install.ps1 script and reproduce the failure with a no_proxy value containing *.chef.io. Check the WebProxy BypassList handling and verify that the script completes and installs Chef without the parsing exception.