0 byte builds cause a silent exit
Open
Nobody has claimed this yet.
Type: Bug
- Dominant language
- Ruby
- Stars
- 13
- Forks
- 55
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 8
Description
Version:
3.11.18
Environment:
Mac OS Mojave 10.14.5
Scenario:
The build is 0 bytes, but since we exit the same way for an error and a zero byte file, that is difficult to determine.
Steps to Reproduce:
mixlib-install install-script | sudo bash -s -- -P inspec -d /tmp -l https://packages.chef.io/files/unstable/inspec/4.7.23/mac_os_x/10.14/inspec-4.7.23-1.dmg
Expected Result:
An error is raised that the build is 0 bytes
Actual Result:
The stderr output of all the tools is raised, which don't appear incorrect unless you notice the size.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at lib/mixlib/install/generator/bourne/scripts/helpers.sh.erb around line 128 and reproduce the install command from the issue. Check how a zero-byte build is handled versus a command error; done means the command reports explicitly that the build is 0 bytes instead of only surfacing tool stderr.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby, shell
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100