chef / chef/knife-ec-backup

Users that fail to be created cause downstream issues with key imports

Open
#148 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Status: Untriaged Type: Bug
Dominant language
Ruby
Stars
32
Forks
28
PR merge metrics
No merged PRs in 30d

Description

Version:

v2.4.6

Environment:

  • Redhat 7
  • Chef Server Core v13.2.0

Scenario:

Restore from backup, e.g. knife ec restore --with-key-sql --with-user-sql

Steps to Reproduce:

Put an invalid email address in any of the users you're restoring.

Expected Result:

I would expect the process to safely handle when a user failed to be created and not error out on the key import process.

Actual Result:

An error is thrown and exits the process immediately

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the knife ec restore --with-key-sql --with-user-sql entry point and reproduce the failure using a restored user with an invalid email address. Trace how a failed user creation is handled before key import, then verify that the restore no longer exits with an error during key import.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend, database
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.