The chef-solo binstubs need to use the Chef::Application::Client class
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 8.2k
- Forks
- 2.5k
- Avg merge
- 4d 5h
- Merged PRs (30d)
- 23
Description
We really need to look at inverting the way that we invoke the Chef::Application::Solo class and then trampoline out of that into Chef::Application::Client when we are in zolo mode and not legacy chef-solo. Instead we should invoke Chef::Application::Client and then only trampoline out when we are in legacy mode, making legacy-mode the special handling case.
This means that command line parsing will have to be made consistent between the classes (and is probably a good thing -- reducing code duplication and interface drift between the two classes). The Chef::Application::Solo class should also likely have its CLI arguments removed, and all the code duplication should really get removed as much as possible.
In the end it would be best to have only Chef::Application::Client exist with special-casing around the legacy mode operation of chef-solo (although its also legacy and at some point we should deprecate that behavior, but that requires fixing the perf issues in ChefFS).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the chef-solo binstubs into Chef::Application::Solo and Chef::Application::Client, then compare how each class parses command-line arguments and handles zolo versus legacy chef-solo mode. Done would mean Client is the primary entry point, legacy mode is the special case, duplicated CLI handling is removed, and the two interfaces are consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- cli, devops
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100