chef / chef/chef-server

dots in usernames verboten

Open
#557 7 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Component: ldap Status: To be prioritized Triage: Confirmed Triage: Try Reproducing Type: Bug
Dominant language
Erlang
Stars
303
Forks
211
Avg merge
1d 8h
Merged PRs (30d)
5

Description

I'm experimenting with LDAP functionality, bolting our standalone Chef server installation (12.2.0, plus some older versions I no longer recall) onto an existing Active Directory domain. The weird restrictions on usernames are getting in my way, specifically the ban on dots, like john.stange. That's a fairly standard corporate convention for usernames. What's the rationale?

Just so we're clear what I'm talking about, asking the REST API to create a user by POSTing the following to /users results in a 400 (Bad Request):

{
 "username": "john.stange",
 "first_name": "John",
 "middle_name": "LDAP",
 "last_name": "Stange",
 "display_name": "John Stange LDAP",
 "email": "john.stange@eglobaltech.com",
 "password": "sometestnonsense"
}

Strip out the dots (set username to johnstange) and it happily complies.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the REST API POST /users entry point and trace the username validation involved in LDAP and Active Directory integrations. Determine where the dot restriction is enforced and clarify whether the intended outcome is permitting dotted usernames or documenting the rationale; done should include a decided behavior for the provided request.

Written by the indexing model from the issue text.

Assessment

Tech stack
erlang
Domain
api, authentication, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.