chef / chef/chef-server

Incorrect metadata in a cookbook causes all client runs on nodes in that org to fail, irrespective of them using the cookbook in question.

Open
#3,335 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Type: Bug
Dominant language
Erlang
Stars
303
Forks
211
Avg merge
1d 8h
Merged PRs (30d)
5

Description

Found a cookbook that had an incorrect format for a dependency made its way into chef, causing the entire service to fail.

It appears the faulty cookbook upload for a single cookbook is taking down an entire chef server

berks -v
7.0.10

knife -v
Chef: 14.15.6

To Reproduce

bundle exec berks upload

Expected behavior

resolution of cookbooks.
A single cookbook to take down an entire chef server seems very dangerous, at the least to improve logging when such events occur so it can be tracked down and resolved.

Actual behavior

08:24:15 [INFO] [2022-04-19T08:24:15-05:00] ERROR: Server returned error 500 for
https://chef.dev.com/organizations/main/environments/cloud_infra_dev_chef16/cookbook_versions, retrying 1/5 in 3s

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failure with bundle exec berks upload and inspect handling of the /cookbook_versions request alongside the reported HTTP 500. Done should mean an invalid dependency in one cookbook no longer prevents unrelated client runs, with enough logging to identify the faulty upload.

Written by the indexing model from the issue text.

Assessment

Tech stack
erlang
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.