Members of the "users" group have delete permission on clients
Nobody has claimed this yet.
- Dominant language
- Erlang
- Stars
- 303
- Forks
- 211
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 5
Description
Currently the "users" group has default "read" and "delete" permissions on the "clients" container. These permissions are inherited by all create clients.
As part of the discussion happening in https://github.com/chef/chef-server/issues/312 we became aware that it wasn't desirable for the "users" group to have default delete permission on the "clients" container and thereby on all created clients. The recommendation is to remove this default.
I'm not sure whether it is reasonable for the "users" group to continue having "read" access but it's probably ok.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the discussion in chef/chef-server issue 312, then locate where default permissions for the "clients" container are defined. Confirm that removing the users group's default delete permission prevents it from being inherited by newly created clients, while preserving the intended read access if appropriate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- erlang
- Domain
- authorization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100