chef / chef/chef-server

Chef Server API should not allow client-names with newline characters

Open
#124 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Status: To be prioritized Triage: Try Reproducing Type: Bug
Dominant language
Erlang
Stars
303
Forks
211
Avg merge
1d 8h
Merged PRs (30d)
5

Description

In the current chef-server we can create a client with name "staging-mike\n".
That should not be allowed.

REF: https://github.com/chef/chef-server/issues/90

Issue noted in : https://getchef.zendesk.com/agent/tickets/3212

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Chef Server API path that creates clients and reproduce the reported client name containing a newline. Trace the request validation and confirm that such names are rejected, using the linked Chef issue and Zendesk ticket for context; done means the API no longer accepts the example name.

Written by the indexing model from the issue text.

Assessment

Tech stack
erlang
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.