Relax constraint on diff-lcs < 1.4
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 18
- Forks
- 23
- Avg merge
- 5d 17h
- Merged PRs (30d)
- 1
Description
Describe the Enhancement
In June 2020, a bug report has been created on diff-lcs about compat issue with chef-cli: halostatue/diff-lcs#65
Since the, a < 1.4.0 constraint has been added to chef-cli dependency on diff-lcs.
I want to relax this constraint and allow the use of recent versions like 1.5.1 because it fixes actual bugs in the diff computation.
It seems the only use of diff-lcs is for the chef-cli diff command; I personnally don't think it is a big deal to finally have proper diff output.
If you think
Describe the Need
Any ruby user depending on chef-cli is currently blocked on old buggy deps :(
Current Alternative
Different Gemfile ... yeah! 👎🏻
Can We Help You Implement This?
I can submit a PR to remove the constraints, but you may want a Breaking change release, I don't know, let me know!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating chef-cli's diff-lcs dependency declaration and the chef-cli diff command. Review the linked diff-lcs compatibility issue and test with a recent version such as 1.5.1; done means the constraint no longer blocks current versions and diff output remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100