cheeaun / cheeaun/phanpy

Editing filters always changes status to Expired unless manually set each time

Open
#521 0 comments 0 reactions 0 assignees View on GitHub
bug in progress
Dominant language
JavaScript
Stars
1.5k
Forks
186
Avg merge
1d 36m
Merged PRs (30d)
11

Description

**Describe the bug**

Editing a filter always changes the status of the filter to "Expired" unless you manually specify the status. It does not preserve the current/already selected status.

- Which site: https://phanpy.social
- Which site version: 2024.04.19.5145730
- Which instance: https://emacs.ch

**To Reproduce**
Steps to reproduce the behavior:
1. Go to Menu > More > Filters
2. Click the edit icon for one of your filters.
3. Click save
4. See the status changed to expired

**Expected behavior**
Filter statuses should retain what is already set, not default to expiring the filter.

**Screenshots**
![2024-04-25__12:51:20](https://github.com/cheeaun/phanpy/assets/76739765/cb507ed7-2cd4-4804-a158-b70c85c5178f)
![2024-04-25__12:51:33](https://github.com/cheeaun/phanpy/assets/76739765/a6319e55-1cdd-47fb-beca-264812ba5848)

As you can see in this filter the status set is "Never Expires"/Never. But unless I manually set a new status every time it will be set to expired. Even when all I want to do is add a keyword. This to me is a bug.

**Desktop (please complete the following information):**
- OS: Linux (Fedora)
- Browser Firefox
- Version 121.0

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.