cheeaun / cheeaun/phanpy

Keyboard shortcut doesn't always respect the OS keyboard layout

Open
#326 4 comments 2 reactions 0 assignees View on GitHub
bug keyboard-shortcuts need-research
Dominant language
JavaScript
Stars
1.5k
Forks
186
Avg merge
1d 36m
Merged PRs (30d)
11

Description

**Describe the bug**

On phanpy.social, with macOS + Chrome, and with a Dvorak keyboard layout, the physical `c` key is mapped to `j` by the Dovark layout. However, hitting that key doesn't cause the `j` keyboard shortcut (next post) as expected. Instead, it triggers the `c` keyboard shortcut (create a new post). Hitting `k` (physical key `v`) works as expected (previous post). Hitting `c` (physical key `i`) also works as expected (create a new post). It's only the physical `c` key that seems to do the physical keyboard shortcut rather than the layout-correct shortcut.

Holding `shift` while hitting `j` (physical `c` key) also does the create-post-in-new-window.

**To Reproduce**
1. Go to `https://phanpy.social/`
2. Hit the `j` key in Dvorak layout on macOS Chrome (physical `c` key)
3. Starts to "create post" as if I had hit the `c` key.

**Expected behavior**
I expect hitting `j` key in Dvorak (physical `c` key) to do the `j` shortcut action.

**Desktop:**
- OS: macOS
- Browser: Chrome
- Version: 119.0.6045.123

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.