cheeaun / cheeaun/phanpy

Emoji missing in emoji reaction notifications

Open
#1,437 5 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
1.5k
Forks
186
Avg merge
1d 36m
Merged PRs (30d)
11

Description

### Site

dev.phanpy.social

### Version

2026.02.04.2aa600d

### Instance

hollo.social

### Browser

- Microsoft Edge 144.0.3719.104 on macOS
- Likely affects all browsers

### Bug description

Emoji reaction notifications show the text “洪 民憙(ホン・ミンヒ)@hongminhee reacted to your post with” but *the emoji itself is not displayed*. The notification appears incomplete with nothing after “with.”

Expected:

```
洪 民憙(ホン・ミンヒ)@hongminhee reacted to your post with 😿
```

Actual:

```
洪 民憙(ホン・ミンヒ)@hongminhee reacted to your post with
```

### To reproduce

1. Use a Hollo instance or any ActivityPub server that supports emoji reactions
2. Have someone react to your post with an emoji (either Unicode emoji or custom emoji)
3. Open Phanpy notifications
4. Observe that emoji reaction notifications show “reacted to your post with” but no emoji is displayed

### Expected behavior

The emoji should be displayed after “reacted to your post with”, either as:

- A Unicode emoji character (for standard emojis like 😿, 🌏)
- A custom emoji image (for custom emojis like `:blobcatthinking:`)

### Other

I've identified the bug in the source code. There's a *parameter name mismatch* in *src/components/notification.jsx*:

https://github.com/cheeaun/phanpy/blob/2aa600d6fac6542650b0cd68036eee9f9be57fa9/src/components/notification.jsx#L446-L450

https://github.com/cheeaun/phanpy/blob/2aa600d6fac6542650b0cd68036eee9f9be57fa9/src/components/notification.jsx#L60-L79

Because the parameter is passed as `emojiURL` but received as `emoji_url`, the value becomes `undefined`. This causes:

1. For custom emojis: `url` and `staticUrl` both become `undefined`
2. The condition `url ? : emoji` should fall back to rendering the text emoji
3. However, even the text emoji (`":blobcatthinking:"`) is not rendered

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.