checkstyle / checkstyle/contribution

diff.groovy throws IllegalStateException on not english locale

Open
#334 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
57
Forks
168
Avg merge
1d 11h
Merged PRs (30d)
15

Description

When executing on another (not english) locale, diff.groove throws IllegalStateException with message:
`Caught: java.lang.IllegalStateException: Error: git repository /home/kazachka/checkstyle has unstaged changes!`
Exception is throwing from here:
https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/diff.groovy#L12
caused because localized git message doesn't contain english text "nothing to commit", so hasUnstagedChanges function returns true.
https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/diff.groovy#L156

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.