chatmail / chatmail/core

Design issue(?): messages can roll back delivered status if atleast one relay does not receive it

Open
#8,241 2 comments 1 reaction 1 assignee Claimed by @iequidoo View on GitHub
Dominant language
Rust
Stars
929
Forks
143
Avg merge
1d 22h
Merged PRs (30d)
59

Description

this is a design flaw that i kind of uncovered after messing around with my own relay, my account currently has 5 relays, 6 before i removed my own,

a message i delivered with the sender relay (which is known good) will be received by my friend, but if my slow and misconfigured relay (either accidentally or on purpose (not in this case)) doesn't know that the message was delivered or thinks it wasn't, the delivery status rolledback in real time

i couldn't take a video of it happening but here are some screenshots of me and my friend freaking out about it before i realized what caused it

bug first noticed by a friend on their end
Image

then my end
Image

me saying i removed my relay
Image

it actually says delivered and doesnt act like the message undelivered
Image

Solution:
I think that chatmail should not prioritise a relay saying a message was undelivered when many other relay did say it was delivered

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.